ok2c commented on a change in pull request #271:
URL:
https://github.com/apache/httpcomponents-core/pull/271#discussion_r584519840
##########
File path:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ClientH2StreamHandler.java
##########
@@ -166,21 +166,18 @@ private void commitRequest(final HttpRequest request,
final EntityDetails entity
@Override
public void produceOutput() throws HttpException, IOException {
- switch (requestState) {
- case HEADERS:
- exchangeHandler.produceRequest(new RequestChannel() {
+ if (requestState == MessageState.HEADERS) {
Review comment:
@arturobernalg Why? What is exactly wrong with `switch case` here? How
is this an improvement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
