ok2c commented on a change in pull request #294:
URL:
https://github.com/apache/httpcomponents-client/pull/294#discussion_r594979139
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProxyClient.java
##########
@@ -158,7 +159,8 @@ public Socket tunnel(
final HttpContext context = new BasicHttpContext();
ClassicHttpResponse response;
- final ClassicHttpRequest connect = new
BasicClassicHttpRequest("CONNECT", host.toHostString());
+ final ClassicHttpRequest connect = new
BasicClassicHttpRequest(Method.CONNECT, host.toHostString());
+ new BasicClassicHttpRequest("CONNECT", host.toHostString());
Review comment:
@arturobernalg This line looks redundant. Is this intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
