carterkozak commented on a change in pull request #296: URL: https://github.com/apache/httpcomponents-client/pull/296#discussion_r597780313
########## File path: httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionMgmtConfig.java ########## @@ -0,0 +1,232 @@ +/* + * ==================================================================== + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * ==================================================================== + * + * This software consists of voluntary contributions made by many + * individuals on behalf of the Apache Software Foundation. For more + * information on the Apache Software Foundation, please see + * <http://www.apache.org/>. + * + */ + +package org.apache.hc.client5.http.config; + +import java.util.concurrent.TimeUnit; + +import org.apache.hc.core5.annotation.Contract; +import org.apache.hc.core5.annotation.ThreadingBehavior; +import org.apache.hc.core5.http.HttpHost; +import org.apache.hc.core5.util.Timeout; + +/** + * Immutable class encapsulating connection initialization and management settings. + * + * @since 5.2 + */ +@Contract(threading = ThreadingBehavior.IMMUTABLE) +public class ConnectionMgmtConfig implements Cloneable { + + private static final Timeout DEFAULT_CONNECTION_REQUEST_TIMEOUT = Timeout.ofMinutes(3); + private static final Timeout DEFAULT_CONNECT_TIMEOUT = Timeout.ofMinutes(3); + + public static final ConnectionMgmtConfig DEFAULT = new Builder().build(); + + private final HttpHost proxy; + private final Timeout socketTimeout; + private final Timeout connectionRequestTimeout; + private final Timeout connectTimeout; + + /** + * Intended for CDI compatibility + */ + protected ConnectionMgmtConfig() { + this(null, null, DEFAULT_CONNECTION_REQUEST_TIMEOUT, DEFAULT_CONNECT_TIMEOUT); + } + + ConnectionMgmtConfig( + final HttpHost proxy, + final Timeout socketTimeout, + final Timeout connectionRequestTimeout, + final Timeout connectTimeout) { + super(); + this.proxy = proxy; + this.socketTimeout = socketTimeout; + this.connectionRequestTimeout = connectionRequestTimeout; + this.connectTimeout = connectTimeout; Review comment: My understanding is that there are two sets of configuration options: 1. Options which apply to the connection pool as a whole 2. Options that may differ based on individual requests I think the `connectTimeout` should generally apply to an entire pool of connections (within a route anyhow), while the `connectionRequestTimeout` is more likely to be configured on a per-request basis. Although if pooling is disabled, that may not be the case, but in the modern era of http/1.1 and greater it's probably reasonable to assume pooling is used. It's not clear to me that all of these options should be configurable per-request, while others should. So I suppose my questions are: Should this be split into two separate configurations for per-pool/route configuration, and per-request configuration? Should the division between `ConnectionMgmtConfig` and `RequestConfig` be different? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
