[
https://issues.apache.org/jira/browse/HTTPCORE-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308708#comment-17308708
]
Carter Kozak commented on HTTPCORE-671:
---------------------------------------
> did you notice HTTPCORE-616?
Yes, this ticket showed up in my initial search before filing this issue, but I
assumed (possibly incorrectly) that the issues were unrelated because this
problem is largely contained within the URIBuilder utility. I'd be happy to
take a look at solving the other issue as well though.
> RFC 2732 is obsolete, I would not take it into account. RFC 3986 is the only
>source of truth.
You are correct, thank you. Unfortunately 3986 is much more difficult to
internalize due to the additional complexity, but it also removes a great deal
of ambiguity.
> URIBuilder incorrectly percent-encodes bracketed ipv6 addresses
> ---------------------------------------------------------------
>
> Key: HTTPCORE-671
> URL: https://issues.apache.org/jira/browse/HTTPCORE-671
> Project: HttpComponents HttpCore
> Issue Type: New Feature
> Components: HttpCore
> Affects Versions: 5.1
> Reporter: Carter Kozak
> Assignee: Carter Kozak
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {code:java}
> new URIBuilder("https://[::1]:432/path";).build();
> Correctly produces 'https://[::1]:432/path'{code}
> {code:java}
> new URIBuilder("https://[::1]:432/path";).setPort(123).build();
> Incorrectly produces 'https://%5B%3A%3A1%5D:123/path'
> where the resulting uri.getPort is -1 and uri.getHost() is null.
> {code}
> The second example fails because we skip the fast path that preserves input
> data when mutations are made.
> I think we need to check for the existence of
> [https://tools.ietf.org/html/rfc2732] brackets in a third branch:
> [https://github.com/apache/httpcomponents-core/blob/cfb6871bd84e0f17068dea1c17d05b848c02ea69/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java#L293-L297]
>
> Alternatively we could strip brackets when we decode/store the host value in
> URIBuilder, however the 'getHost' result might be confusing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
