ok2c commented on a change in pull request #274:
URL:
https://github.com/apache/httpcomponents-core/pull/274#discussion_r602449044
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java
##########
@@ -292,6 +292,8 @@ private String buildString() {
}
if (InetAddressUtils.isIPv6Address(this.host)) {
sb.append("[").append(this.host).append("]");
+ } else if
(InetAddressUtils.isIPv6URLBracketedAddress(this.host)) {
Review comment:
> This also results in unintuitive and inconsistent behavior due to the
fact that `URIBuilder` uses `URI#getRawAuthority` by default and then clears
the authority if any part of it changes.
@pkoenig10 I just want to point out that `java.net.URI` does not conform to
RFC 3986. It conforms to RFC 2396 only. Behavioral inconsistencies between
`java.net.URI` and `URIBuilder` are to be expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
