ok2c edited a comment on pull request #277:
URL: 
https://github.com/apache/httpcomponents-core/pull/277#issuecomment-811286447


   @rschmitt 
   The trouble is this spot:
   
https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java#L277
   
   There is small window between a least request timeout and its cancellation 
when the pool can still produce a pool entry and stick it into the request 
future before it gets cancelled, in which can the pool entry never gets 
released back to the pool.
   
   The only reliable fix I have found is to cancel the request at the time of 
timeout.
   
   Please review and test locally.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to