michael-o commented on pull request #279: URL: https://github.com/apache/httpcomponents-core/pull/279#issuecomment-814363461
> > > @carterkozak @michael-o In ideal situation there should have been only `Host` and `URIAuthority` classes and no `HttpHost`. I opted to keep `HttpHost` for the sake of backward compatibility due to its widespread use in 4.x. I am really not sure `URIAuthority` should extend `Host`. Please also note all three classes implement `NamedEndpoint` interface, which is something they all share in common. Ideally, yes. `URIAuthority` should not extend `Host` but simply delegate the required part to it. I don't see a reason why the subtext after `@` should not be handled by Host. > Having said all that it should not prevent us from re-using parsing and formatting logic. > I can look into that once you are happy with IPv6 specific aspects. Absolutely, I'd be happy to review/consult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
