peterdettman commented on a change in pull request #302:
URL:
https://github.com/apache/httpcomponents-client/pull/302#discussion_r610634373
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java
##########
@@ -114,18 +114,15 @@ public void verify(
matchIPv6Address(host, subjectAlts);
break;
default:
- matchDNSName(host, subjectAlts, this.publicSuffixMatcher);
+ // In case there are no SubjectName.DNS entries, fallback
to CN matching
Review comment:
Yes, matchDNSNames is only returning false if there were no dNSName at
all. If there were any present that didn’t match, it would have already thrown
an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
