ok2c commented on a change in pull request #304:
URL:
https://github.com/apache/httpcomponents-client/pull/304#discussion_r619834850
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/InternalAbstractHttpAsyncClient.java
##########
@@ -122,6 +129,7 @@ void internalClose(final CloseMode closeMode) {
}
}
}
+ this.scheduledExecutorService.shutdown();
Review comment:
@michael-o The scheduler merely submits requests for execution, it does
not actually execute them. However it probably makes sense to shut down the
executor immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
