On Sun, 2021-05-02 at 17:03 -0400, Gary Gregory wrote: > I did not create a PR, I meant to say something along the lines of: > Either > we fix the build on Java 16 or we give a reason why it is not > expected to > build on Java 16. Sorry for the lack of clarity. >
Who _exactly_ is going fix the build on Java 16 and why do we need to say anything? Did anyone raise a JIRA and assigned it to release 5.0.4 and 5.1.1? Oleg > Gary > > On Sun, May 2, 2021, 14:42 Oleg Kalnichevski <[email protected]> > wrote: > > > On Sun, 2021-05-02 at 10:05 -0400, Gary Gregory wrote: > > > Reserving VOTE until Java 16 issue is resolved. > > > > > > > Hi Gary > > > > Have I missed your pull request somehow? > > > > Oleg > > > > > > > Tested on macOS with Java 8, 11, 16. > > > > > > Fails on Java 16.0.1 with: mvn clean package -V -P\!use- > > > toolchains > > > > > > [ERROR] Tests run: 19, Failures: 3, Errors: 0, Skipped: 0, Time > > > elapsed: 0.06 s <<< FAILURE! - in > > > org.apache.hc.core5.http.impl.io.TestBHttpConnectionBase > > > [ERROR] > > > org.apache.hc.core5.http.impl.io.TestBHttpConnectionBase.testAwai > > > tInp > > > utInBuffer > > > Time elapsed: 0.032 s <<< FAILURE! > > > java.lang.AssertionError > > > at > > > org.apache.hc.core5.http.impl.io.TestBHttpConnectionBase.testAwai > > > tInp > > > utInBuffer(TestBHttpConnectionBase.java:251) > > > > > > [ERROR] > > > org.apache.hc.core5.http.impl.io.TestBHttpConnectionBase.testNotS > > > tale > > > WhenHasData > > > Time elapsed: 0 s <<< FAILURE! > > > java.lang.AssertionError > > > at > > > org.apache.hc.core5.http.impl.io.TestBHttpConnectionBase.testNotS > > > tale > > > WhenHasData(TestBHttpConnectionBase.java:310) > > > > > > [ERROR] > > > org.apache.hc.core5.http.impl.io.TestBHttpConnectionBase.testAwai > > > tInp > > > utInSocket > > > Time elapsed: 0.001 s <<< FAILURE! > > > java.lang.AssertionError > > > at > > > org.apache.hc.core5.http.impl.io.TestBHttpConnectionBase.testAwai > > > tInp > > > utInSocket(TestBHttpConnectionBase.java:268) > > > > > > [INFO] Running > > > org.apache.hc.core5.http.impl.io.TestSessionInOutBuffers > > > [ERROR] Tests run: 21, Failures: 0, Errors: 2, Skipped: 0, Time > > > elapsed: 0.04 s <<< FAILURE! - in > > > org.apache.hc.core5.http.impl.io.TestSessionInOutBuffers > > > [ERROR] > > > org.apache.hc.core5.http.impl.io.TestSessionInOutBuffers.testWrit > > > eSma > > > llFragmentNoBuffering > > > Time elapsed: 0.023 s <<< ERROR! > > > java.lang.NullPointerException: Cannot read the array length > > > because > > > "this.buf" is null > > > at > > > org.apache.hc.core5.http.impl.io.TestSessionInOutBuffers.testWrit > > > eSma > > > llFragmentNoBuffering(TestSessionInOutBuffers.java:388) > > > > > > [ERROR] > > > org.apache.hc.core5.http.impl.io.TestSessionInOutBuffers.testWrit > > > eSma > > > llFragmentBuffering > > > Time elapsed: 0 s <<< ERROR! > > > java.lang.NullPointerException: Cannot read the array length > > > because > > > "this.buf" is null > > > at > > > org.apache.hc.core5.http.impl.io.TestSessionInOutBuffers.testWrit > > > eSma > > > llFragmentBuffering(TestSessionInOutBuffers.java:379) > > > > > > Tests on Java 8, 11: > > > Apache RAT check OK. > > > Apache CLIRR check OK. > > > Apache package build OK. > > > Disabled toolchain for Java 7. > > > > > > Maven and Java versions: > > > > > > Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) > > > Maven home: /usr/local/Cellar/maven/3.8.1/libexec > > > Java version: 1.8.0_292, vendor: AdoptOpenJDK, runtime: > > > /Library/Java/JavaVirtualMachines/adoptopenjdk- > > > 8.jdk/Contents/Home/jre > > > Default locale: en_US, platform encoding: UTF-8 > > > OS name: "mac os x", version: "10.16", arch: "x86_64", family: > > > "mac" > > > > > > Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) > > > Maven home: /usr/local/Cellar/maven/3.8.1/libexec > > > Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: > > > /Library/Java/JavaVirtualMachines/adoptopenjdk- > > > 11.jdk/Contents/Home > > > Default locale: en_US, platform encoding: UTF-8 > > > OS name: "mac os x", version: "11.3", arch: "x86_64", family: > > > "mac" > > > > > > Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) > > > Maven home: /usr/local/Cellar/maven/3.8.1/libexec > > > Java version: 16.0.1, vendor: AdoptOpenJDK, runtime: > > > /Library/Java/JavaVirtualMachines/adoptopenjdk- > > > 16.jdk/Contents/Home > > > Default locale: en_US, platform encoding: UTF-8 > > > OS name: "mac os x", version: "11.3", arch: "x86_64", family: > > > "mac" > > > > > > Gary > > > > > > On Sun, May 2, 2021 at 4:44 AM Oleg Kalnichevski < > > > [email protected]> > > > wrote: > > > > Please vote on releasing these packages as HttpCore 5.0.4. > > > > The vote is open for the at least 72 hours, and only votes from > > > > HttpComponents PMC members are binding. The vote passes if at > > > > least > > > > three binding +1 votes are cast and there are more +1 than -1 > > > > votes. > > > > > > > > Release notes: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0.4-RC1/RELEASE_NOTES-5.0.x.txt > > > > Maven artefacts: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehttpcomponents-1131/org/apache/httpcomponents/core5/ > > > > Git Tag: 5.0.4-RC1 > > > > https://github.com/apache/httpcomponents-core/tree/5.0.4-RC1 > > > > > > > > Packages: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0.4-RC1 > > > > revision 47502 > > > > > > > > Hashes: > > > > b83cad4ffb22f1f7faa39e191acdad1b003490f238132cd85cc9b0d38a7f0c > > > > 8ba3 > > > > 3670206c2f177f8c37bf7308e2f4a786632295c9b05681618510aee0134b20 > > > > httpcomponents-core-5.0.4-src.zip > > > > eb1bbf13d901335403d5d20c07c4c1160e8e9876b94cbeebb07cf86c337cc4 > > > > 9d5a > > > > afe7066c37a730f372e30a3486be34eece3642a649ef9eecd5963574a4c69f > > > > httpcomponents-core-5.0.4-src.tar.gz > > > > 62755f29c872425a4bf8e6c835b7a11deec80048f94069a702b702615d4b9f > > > > ff2b > > > > ed7ad366aafae05095b5f09d82557ba590fdb63b90b57a2500d8bc0aa16148 > > > > httpcomponents-core-5.0.4-bin.zip > > > > f76513eb8cd7d4faa60adbbe34aa44f8ecba5990d86815f5ecf28b0905cdc9 > > > > 1986 > > > > 5d02d964592ede68af358adb3a2385cbfb2536e2715f9b2d22e9441e1857ac > > > > httpcomponents-core-5.0.4-bin.tar.gz > > > > > > > > Keys: > > > > https://www.apache.org/dist/httpcomponents/httpcore/KEYS > > > > > > > > ------------------------------------------------------------- > > > > ---- > > > > --------- > > > > Vote: HttpCore 5.0.4 release > > > > [ ] +1 Release the packages as HttpCore 5.0.4. > > > > [ ] -1 I am against releasing the packages (must include a > > > > reason). > > > > > > > > > > > > ------------------------------------------------------------- > > > > ---- > > > > ---- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > --------------------------------------------------------------- > > > ------ > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > ----------------------------------------------------------------- > > ---- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
