carterkozak commented on a change in pull request #286:
URL: 
https://github.com/apache/httpcomponents-core/pull/286#discussion_r641980377



##########
File path: 
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/ssl/H2TlsSupport.java
##########
@@ -46,6 +46,10 @@ public static void setEnableRetransmissions(final 
SSLParameters sslParameters, f
         ReflectionUtils.callSetter(sslParameters, "EnableRetransmissions", 
Boolean.TYPE, value);
     }
 
+    /**
+     * @deprecated Use {@link SSLParameters#setApplicationProtocols(String[])}.
+     */
+    @Deprecated
     public static void setApplicationProtocols(final SSLParameters 
sslParameters, final String[] values) {
         ReflectionUtils.callSetter(sslParameters, "ApplicationProtocols", 
String[].class, values);

Review comment:
       Any reason not to update this call to 
`sslParameters.setApplicationProtocols(values);`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to