ok2c commented on pull request #310: URL: https://github.com/apache/httpcomponents-core/pull/310#issuecomment-954757071
> > > get the benefits. > > > > > > @garydgregory What would those be? Nanosecond time resolution for timeout calculation with 1s precision? > > The most important aspect of this type of change is type safety. On Java 8, we can use objects like Instant and Duration instead of a mix of int and long which appear unscaled and are subject to underflow, overflow, and wrap around behavior. Not to mention that sometimes an argument is expressed in seconds, sometimes it's in milliseconds, a sure recipe for bugs. @garydgregory This is a legitimate reason but not for low level classes where memory footprint matters more. If have spare cycles better invest them into porting high level APIs (such those in the cookie and cache packages) from `Date` to `Instance`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
