michael-o commented on a change in pull request #320:
URL:
https://github.com/apache/httpcomponents-client/pull/320#discussion_r740130776
##########
File path:
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java
##########
@@ -118,6 +118,20 @@ public void
testMultipartCustomContentTypeParameterOverrides() throws Exception
entity.getContentType());
}
+ @Test
+ public void testMultipartCustomContentTypeUsingAddParameter() {
+ final MultipartEntityBuilder eb = MultipartEntityBuilder.create();
+ eb.setMimeSubtype("related");
+ eb.addParameter(new BasicNameValuePair("boundary", "yada-yada"));
+ eb.addParameter(new BasicNameValuePair("charset", "ascii"));
+ eb.addParameter(new BasicNameValuePair("my", "stuff"));
+ eb.buildEntity();
+ final MultipartFormEntity entity = eb.buildEntity();
+ Assert.assertNotNull(entity);
+ Assert.assertEquals("multipart/related; boundary=yada-yada;
charset=US-ASCII; my=stuff",
Review comment:
True...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
