[
https://issues.apache.org/jira/browse/HTTPCLIENT-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442952#comment-17442952
]
ASF subversion and git services commented on HTTPCLIENT-2184:
-------------------------------------------------------------
Commit e09c5d0691a23ef06e36bae6986c8fe373580eb7 in httpcomponents-client's
branch refs/heads/master from Carter Kozak
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=e09c5d0 ]
HTTPCLIENT-2184: Fix classic client connection reuse
This fixes an issue in which connections were not returned to the
pool when requests contained non-repeatable bodies AND responses
were streamed. When both of these criteria were met, responses
were returned without ResponseEntityProxy enhancements so that
closing the response entity or stream no longer completed the
exchange, thus leaking the connection which forever lived in the
`leased` state in the connection pool.
> Leased Connection Leak after upgrade to 5.1.1
> ---------------------------------------------
>
> Key: HTTPCLIENT-2184
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2184
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (classic)
> Affects Versions: 5.1.1
> Reporter: Carter Kozak
> Assignee: Carter Kozak
> Priority: Critical
> Attachments: 2021-11-11_1095x517_screen.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Unfortunately I haven't had a chance to build a local reproducer yet, nor
> have I had a chance to profile a system experiencing this failure – I intend
> to add additional data to this ticket later on as I debug.
> I do have a system deployed where the issue does not reproduce on 5.1, but I
> can redeploy only changing the httpcomponents-client jar to 5.1.1 (no other
> transitive dependency changes, etc) and the leak appears. This should rule
> out bad application code as a root cause, I also have metrics which capture
> any time a response is not closed, which reports zero leaks in both cases.
> I have attached a graph of my connection pool leased-connections metric, the
> blue line in the middle represents the first version which took
> httpcomponents-client 5.1.1, where previously leased connections sat right
> around zero. There's a short gap after the blue line ends where we rolled
> back to the previous release, followed by a few smaller successful attempts
> to reproduce the issue resulting in large sets of leased connections.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
