ok2c commented on a change in pull request #325:
URL:
https://github.com/apache/httpcomponents-client/pull/325#discussion_r748704099
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java
##########
@@ -201,13 +201,15 @@ public ClassicHttpResponse execute(
if (Method.TRACE.isSame(request.getMethod())) {
// Do not perform authentication for TRACE request
+ ResponseEntityProxy.enhance(response, execRuntime);
Review comment:
@schlosna All responses returned by the `ProtocolExec` interceptor must
be enhanced to automatically release the underlying connection upon response
content consumption. There is certainly a room for minor refactoring. Feel free
to propose a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
