ok2c commented on a change in pull request #333:
URL:
https://github.com/apache/httpcomponents-core/pull/333#discussion_r753674363
##########
File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java
##########
@@ -69,6 +73,27 @@ public void testConstructor() {
Assert.assertThrows(NullPointerException.class, () -> new
HttpHost(null, (String) null, -1));
Assert.assertThrows(IllegalArgumentException.class, () -> new
HttpHost(null, " ", -1));
Assert.assertThrows(NullPointerException.class, () -> new
HttpHost(null, (InetAddress) null, -1));
+
+ final Host host = new Host("myHost", 8080);
Review comment:
No, not nothing. I am going to deprecate `public HttpHost(final
URIAuthority authority)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
