arturobernalg commented on pull request #330:
URL:
https://github.com/apache/httpcomponents-client/pull/330#issuecomment-980696592
> 1. coupled
> @arturobernalg
>
> 1. The `Cookie` interface is now coupled with `DateUtils` which is ugly.
Please expand those utility methods and remove dependency on `DateUtils`. A bit
of code duplication is justified in this particular case.
> 2. Is `@SuppressWarnings("DeprecatedIsStillUsed")` better than shorter
@SuppressWarnings("deprecation")? Just asking.
> 3. There are still several places where deprecated code is being used and
causes deprecation warning at compile time. We need to get rid of those. I also
propose that test cases for deprecated methods get dropped. No need to keep
them if new methods pass the same test. Ideally there should be no deprecation
warnings.
HI @ok2c
All the remark fixed.
About using `@SuppressWarnings("DeprecatedIsStillUsed")` instead of
`@SuppressWarnings("deprecation")` it just because the IDE show me a warning of
redundant with `deprecation `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
