ok2c commented on a change in pull request #330:
URL: 
https://github.com/apache/httpcomponents-client/pull/330#discussion_r757808727



##########
File path: 
httpclient5/src/main/java/org/apache/hc/client5/http/cookie/Cookie.java
##########
@@ -77,9 +78,26 @@
      * considered immutable. Changing it (e.g. using setTime()) could result
      * in undefined behaviour. Do so at your peril. </p>
      * @return Expiration {@link Date}, or {@code null}.
+     * @deprecated Use {{@link #getExpiryInstant()}}
      */
+    @SuppressWarnings("DeprecatedIsStillUsed")
+    @Deprecated
     Date getExpiryDate();

Review comment:
       > The annotations @SuppressWarnings support method. through this ways no 
need annotated where it is used.
   
   @arturobernalg This is not a matter of taste or preference. Consumers of the 
library must be warned about API deprecation. The _only_ exception is the 
internal use of deprecated methods required for backward compatibility. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to