ok2c commented on a change in pull request #332:
URL: 
https://github.com/apache/httpcomponents-client/pull/332#discussion_r767134343



##########
File path: 
httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpCacheStorage.java
##########
@@ -94,4 +94,14 @@ void updateEntry(
      */
     Map<String, HttpCacheEntry> getEntries(Collection<String> keys) throws 
ResourceIOException;
 
+    /**
+     * Check if the cache is still active and has not shut down.
+     *
+     * @return {@code true} if the cache is active, otherwise return {@code 
false}.
+     * @since 5.2
+     */
+    default boolean isActive() {

Review comment:
       @arturobernalg Why adding this method to `HttpCacheStorage` when it 
clearly applies to `ManagedHttpCacheStorage` only and it makes no sense for all 
other implementations?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to