arturobernalg commented on pull request #346: URL: https://github.com/apache/httpcomponents-client/pull/346#issuecomment-1012531216
> > @arturobernalg I really do not want to be nasty, but why this particular place? There must be hundreds places where arg checks are missing. Why this place and not all others? Please, please finally start working on some feature and while doing so feel free to improve the code you touch, but these one line PRs you have been raising are just not very useful. > > @ok2c agree that there hundreds places where arg checks are missing, but don't you thing is time to face to problem and solved? I´m trying to improve the code. Every time that I found something susceptible to improvement I change it and I make a pr.I'm trying to fallow the guide that you send in the mail, but keep in mind that is not an easy code and required a lot a functional expertise and a deep knowledge in the code and the standard. I'm working on it, but it's a slow process and need to go through in order to be more productive. TY @ok2c and maybe for you it's an insignificant change, but improve the code and do it better for all the community. sn't that really the idea and essence of collaboration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
