[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dillon Krompetz updated HTTPCLIENT-2214:
----------------------------------------
    Description: 
Similar to https://issues.apache.org/jira/browse/HTTPCLIENT-2202

There also seems to have been a similar regression from 4.x to 5.x in terms of 
using hard implementations of MemcachedClient object over interface 
MemcachedClientIF.

Changing to use MemcachedClientIF would again here be backwards compatible due 
to Memcached.
{code:java}
public class MemcachedHttpAsyncCacheStorage extends 
AbstractBinaryAsyncCacheStorage<CASValue<Object>> {

private final MemcachedClient client;
private final KeyHashingScheme keyHashingScheme;

public MemcachedHttpAsyncCacheStorage(final InetSocketAddress address) throws 
IOException { 
  this(new MemcachedClient(address)); 
} 

...{code}

  was:
Similar to https://issues.apache.org/jira/browse/HTTPCLIENT-2202

There also seems to have been a similar regression from 4.x to 5.x in terms of 
using hard implementations of MemcachedClient object over interface 
MemcachedClientIF.

Changing to use MemcachedClientIF would again here be backwards compatible due 
to Memcached.

```

public class MemcachedHttpAsyncCacheStorage extends 
AbstractBinaryAsyncCacheStorage<CASValue<Object>> {

private final MemcachedClient client;
private final KeyHashingScheme keyHashingScheme;

public MemcachedHttpAsyncCacheStorage(final InetSocketAddress address) throws 
IOException {
this(new MemcachedClient(address));
}

```


> MemcachedHttpAsyncCacheStorage should use MemcachedClientIF interface
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2214
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2214
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCache
>    Affects Versions: 5.0, 5.1, 5.1.2, 5.1.3
>            Reporter: Dillon Krompetz
>            Priority: Minor
>
> Similar to https://issues.apache.org/jira/browse/HTTPCLIENT-2202
> There also seems to have been a similar regression from 4.x to 5.x in terms 
> of using hard implementations of MemcachedClient object over interface 
> MemcachedClientIF.
> Changing to use MemcachedClientIF would again here be backwards compatible 
> due to Memcached.
> {code:java}
> public class MemcachedHttpAsyncCacheStorage extends 
> AbstractBinaryAsyncCacheStorage<CASValue<Object>> {
> private final MemcachedClient client;
> private final KeyHashingScheme keyHashingScheme;
> public MemcachedHttpAsyncCacheStorage(final InetSocketAddress address) throws 
> IOException { 
>   this(new MemcachedClient(address)); 
> } 
> ...{code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to