michael-o commented on code in PR #363:
URL:
https://github.com/apache/httpcomponents-client/pull/363#discussion_r874789738
##########
pom.xml:
##########
@@ -148,6 +149,11 @@
<artifactId>commons-codec</artifactId>
<version>${commons-codec.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.brotli</groupId>
+ <artifactId>dec</artifactId>
Review Comment:
Very bad choice for an artifactId from the brotli team. (not related to this
PR)
##########
pom.xml:
##########
@@ -65,6 +65,7 @@
<httpcore.version>5.2-beta1</httpcore.version>
<log4j.version>2.17.0</log4j.version>
<commons-codec.version>1.15</commons-codec.version>
+ <dec.version>0.1.2</dec.version>
Review Comment:
Please rename to brotli. `dec` is a quite generic name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
