[
https://issues.apache.org/jira/browse/HTTPCLIENT-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600909#comment-17600909
]
Gary D. Gregory commented on HTTPCLIENT-2234:
---------------------------------------------
Please, no.
Shading is a horror show. Duplication is a code smell.
Shading should IMO only be done by standalone applications.
I was just faced with the beyond obnoxious situation where I was coding for an
application where two of its dependencies shade the same third party library.
This is lunacy, let the standaline application decide what to package and how.
Shading without repackaging is just another form of jar hell.
Serving up copy pasta of depencies is not a good thing.
> remove dependency on commons-codec in older versions of http-client
> -------------------------------------------------------------------
>
> Key: HTTPCLIENT-2234
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2234
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
> Affects Versions: 5.1.3
> Reporter: Johannes Graham
> Priority: Minor
>
> This would effectively be a backport of HTTPCLIENT-2218.
> The commons-codec jar file is about 345k, but only a small fraction of it is
> relevant to http-client.
> If there is any interest in pursuing this, I would be willing to provide a PR
> for it.
> My initial proposal for implementing this would be to pull the relevant code
> from commons-codec and include a simplified version of it in this project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
