My biggest worry is folks complaining about incompatibility with earlier SOCKS versions like SOCKK4 but I only see a passing reference to that on https://en.wikipedia.org/wiki/SOCKS#SOCKS5 without a precise reference to or in https://datatracker.ietf.org/doc/html/rfc1928
"The SOCKS5 protocol is defined in RFC 1928. It is an incompatible extension of the SOCKS4 protocol..." That is a pain indeed. Gary On 2022/11/17 18:36:01 Oleg Kalnichevski wrote: > Folks > > TLS over SOCKS is broken in HC 5.2 and likely 5.1 as well. The problem > represents a very common pattern in this project. Some external > contributor contributed a substantial chunk of code and happily moved > on, leaving us with a piece of functionality none of us had any > knowledge or even interest of. > > I had to learn SOCKS5 protocol in the past few days even though I do > not use it personally and frankly could not care less about. > > Feel free to review and complain about the change-set before I merge > it. > > https://github.com/apache/httpcomponents-core/compare/master...socks5 > > Oleg > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
