michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1346334453
> > Don't add runtime exceptions to method signatures. They belong into Javadoc. See Effective Java from Joshua Bloch. > > @michael-o I must say I disagree with Joshua Bloch in this particular instance. There is no negative runtime impact from declaration of runtime exceptions in the throws clause. Essentially it is a matter of taste rather anything else. But so be it. I'll remove it. I agree wth you, correct, there is no negative impact, but runtime exceptions denote a irrecoverable state mostly due to programming errors: shit in, shit out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
