michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374437550
> > > @michael-o Out of curiosity, how long do you intend to block this PR? > > > > > > ??? There are still unresolved issues: > > Issues? > > > ``` > > * `toString()` unnecessarily exposes the token > > ``` > > Why is this an issue, let alone a blocker? I bet there will be clowns complaining about this. I never wrote that this is a blocker. > > ``` > > * `error_uri` is not passed > > ``` > > Why is this an issue? Is there a MUST or SHOULD requirement? This is merely logging, which I am happy to tweak to your personal liking, but I still do not know _how_ exactly you want log entries to look like. Look at your answer here: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1355338254 You wrote: I will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
