ok2c commented on PR #390:
URL: 
https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1436996145

   @arturobernalg Almost there. Now consider the case when the 
`EndpointDetails` is null (not present in the execution context). What 
`forwarded` value would the interceptor produce? Please make sure that your 
code either adds a valid header, throws an exception or does nothing. It should 
never produce a malformed header no matter circumstances. A test case for the 
`EndpointDetails` being null would also be nice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to