ok2c commented on code in PR #433:
URL:
https://github.com/apache/httpcomponents-client/pull/433#discussion_r1174524383
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CachedResponseSuitabilityChecker.java:
##########
@@ -241,6 +246,26 @@ public boolean canCachedResponseBeUsed(final HttpHost
host, final HttpRequest re
return true;
}
+ /**
+ * Determine if I can utilize a {@link HttpCacheEntry} to respond to the
given
+ * {@link HttpRequest}
+ *
+ * @param host
+ * {@link HttpHost}
+ * @param request
+ * {@link HttpRequest}
+ * @param entry
+ * {@link HttpCacheEntry}
+ * @param now
+ * Right now in time
+ * @return boolean yes/no answer
+ * @deprecated (5.3) use {@link #canCachedResponseBeUsed(HttpRequest,
HttpCacheEntry, Instant)}
+ */
+ @Deprecated
Review Comment:
@arturobernalg This class is package private. There is no need deprecate old
methods. Just remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
