ok2c commented on code in PR #446:
URL:
https://github.com/apache/httpcomponents-client/pull/446#discussion_r1193118447
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheControlHeaderParser.java:
##########
@@ -162,6 +169,19 @@ public final CacheControl parse(final Header header) {
mustRevalidate = true;
} else if
(name.equalsIgnoreCase(HeaderConstants.CACHE_CONTROL_NO_CACHE)) {
noCache = true;
+ if (value != null) {
+ final Tokenizer.Cursor valueCursor = new
Tokenizer.Cursor(cursor.getPos() - value.length() -1, buffer.length());
Review Comment:
@arturobernalg My apologies. My suggestion was completely unfounded. Your
initial implementation was perfectly fine. I restored it in your commit. Sorry
about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
