MikailBag commented on PR #474: URL: https://github.com/apache/httpcomponents-client/pull/474#issuecomment-1673328398
> Could you please provide some insight into the handling of other synchronization blocks within the code? This particular `synchronized` block pinning was actually caught in practice, so I changed it. I initially chose not to touch other blocks since I'm not sure if blocking inside them is possible or not. Other than that, I have no objections to replacing all other blocks. > I would leave 4.x be and make sure 5.x works correctly with the newest JREs. If I don't mix things up, this PR is opened against 5.x code. > My vote is to do nothing until virtual threads, which are only out of beta in Java 21, are fully debugged and accepted. In JDK early access releases they should be already usable without any `--enable-preview` flags. Anyway, I guess I understand your position. Maybe this pull request should be closed/postponed until JDK 21 is released. Thank you in advance for providing fast feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
