arturobernalg commented on code in PR #477:
URL:
https://github.com/apache/httpcomponents-client/pull/477#discussion_r1300653728
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java:
##########
@@ -328,7 +330,7 @@ public HttpCacheStorageEntry deserialize(final byte[]
serializedObject) throws R
statusLine.getStatusCode(),
responseHeaders,
resource,
- variantMap
+ !variants.isEmpty() ? variants : null
Review Comment:
Shouldn't we delegate everything to the internal constructor of
`HttpCacheEntry`? I think its redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
