bpitman commented on PR #422: URL: https://github.com/apache/httpcomponents-core/pull/422#issuecomment-1694405377
Passing on intent from PR 421: I understand that you want no more connection/tls configuration in HttpRequest beyond what can be expressed in URI. In this case, why does the Builder have a setter for HttpHost? It adds no functionality that isn't supported in other setters. As an end user, it's only value is to add a resolved InetAddress. If the address won't be used, then the setter only adds confusion. I think it should be deprecated and removed. If you're not going to do this, at least update the javadoc to explain that the address is lost in the request object; add a pointer to the way the request should be executed if the address needs to be preserved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
