ok2c commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312747037
##########
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##########
@@ -260,41 +260,41 @@ public void cancelled() {
@Test
void testGetWithTimeout() {
+ final AtomicBoolean isFutureCompleted = new AtomicBoolean(false);
Review Comment:
@arturobernalg Looks good, but there appears to be unrelated change in the
change-set. Please move it into a separate commit or a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
