ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312913134
##########
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##########
@@ -110,21 +112,56 @@ public void process(final HttpRequest request, final
EntityDetails entity, final
}
}
if (entity != null) {
+
Review Comment:
@arturobernalg Nooooooooo. Cmon! Some entities stream their content and
their length is not known it advance! This is what you have `EntityDetails`
for. Basically if it is non-null there is an enclosed entity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
