[
https://issues.apache.org/jira/browse/HTTPCLIENT-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791619#comment-17791619
]
Oleg Kalnichevski commented on HTTPCLIENT-2310:
-----------------------------------------------
[~marianbabii] I would really appreciate if you could test this PR locally
before it gets merged. Proxy related issues are extremely difficult to test and
would very much appreciate some help
[https://github.com/apache/httpcomponents-client/pull/516]
Please also let me know why you think one may need to intercept CONNECT
requests and I may be able to propose an alternative solution
Oleg
> Async client incorrectly pipes CONNECT requests through the main request
> protocol chain
> ---------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2310
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2310
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (classic)
> Affects Versions: 5.2.2, 5.2.1
> Reporter: Marian
> Priority: Minor
> Fix For: 5.3-alpha2
>
> Attachments: image-2023-11-28-15-12-04-268.png,
> image-2023-11-28-15-12-20-327.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HttpRequestInterceptor can be added to both CloseableHttpClient and
> CloseableHttpAsyncClient, but a CONNECT request can be caught only with
> CloseableHttpAsyncClient.
> Even if I use the following examples: [for
> async|https://github.com/apache/httpcomponents-client/blob/5.2.x/httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientInterceptors.java]
> or [for
> classic|https://github.com/apache/httpcomponents-client/blob/5.2.x/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientInterceptors.java]
> from GitHub.
> Could it be possible to fix this issue and cover the "connect" request in
> CloseableHttpClient's request interceptor?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
