[
https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicklas Wallgren updated HTTPCLIENT-2366:
-----------------------------------------
Description:
The behavior of {{RequestEntityProxy#isRepeatable}} changed in [this
commit|https://github.com/apache/httpcomponents-client/commit/a1eed8084de7c58203a6acb799b7e4b04f669d39#r154843658],
where the method now returns {{false}} unless {{writeTo()}} has already been
called.
This appears to be a regression. Previously, an entity was considered
repeatable as long as it hadn't been consumed yet and the original entity
itself was repeatable. The new logic incorrectly assumes that an entity is only
repeatable _after_ it's been consumed, which defeats the purpose of determining
retry eligibility _before_ transmission.
was:
The behavior of {{RequestEntityProxy#isRepeatable}} changed in [this
commit|https://github.com/apache/httpcomponents-client/commit/a1eed8084de7c58203a6acb799b7e4b04f669d39#r154843658],
where the method now returns {{false}} unless {{writeTo()}} has already been
called.
This appears to be a regression. Previously, an entity was considered
repeatable as long as it hadn't been consumed yet and the original entity
itself was repeatable. The new logic incorrectly assumes that an entity is only
repeatable _after_ it's been consumed, which defeats the purpose of determining
retry eligibility _before_ transmission.
Since I don't have access to Jira or the Slack channel, I'm submitting the bug
report here instead.
> HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false
> before entity is consumed
> -------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2366
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2366
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (classic)
> Reporter: Nicklas Wallgren
> Priority: Major
>
> The behavior of {{RequestEntityProxy#isRepeatable}} changed in [this
> commit|https://github.com/apache/httpcomponents-client/commit/a1eed8084de7c58203a6acb799b7e4b04f669d39#r154843658],
> where the method now returns {{false}} unless {{writeTo()}} has already been
> called.
> This appears to be a regression. Previously, an entity was considered
> repeatable as long as it hadn't been consumed yet and the original entity
> itself was repeatable. The new logic incorrectly assumes that an entity is
> only repeatable _after_ it's been consumed, which defeats the purpose of
> determining retry eligibility _before_ transmission.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
