On Tue, 2025-04-08 at 13:49 -0700, Ryan Schmitt wrote: > Hi Oleg, > > I figured it out. The TlsConfig option indeed does work if you set it > on a custom connection manager that you then supply to > HttpAsyncClients::createMinimal. The way the deprecated factory > method > is doing this internally still appears to be incorrect (since it's > just creating a default connection manager). > > Additionally, I noticed a breaking ABI change in httpcore 5.3.4. The > method signature of a public constructor for ClientH2UpgradeHandler > was changed. I'm surprised, because I thought we were using Apache > Rat > to detect this sort of thing. Maybe I misunderstand the compatibility > contract between different versions of httpcore and httpclient. >
Hi Ryan We do have API compatibility checks in place using JApiCmp. ClientH2UpgradeHandler has been marked as @Internal and is therefore excluded from the check. There are several classes with public visibility that are not quite ready for general availability. If you want ClientH2UpgradeHandler to be made a part of the public APIs we need to drop @Internal on it in the next feature release. Cheers Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
