ok2c commented on code in PR #634:
URL:
https://github.com/apache/httpcomponents-client/pull/634#discussion_r2071369880
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/InternalAbstractHttpAsyncClient.java:
##########
@@ -219,6 +220,7 @@ protected <T> Future<T> doExecute(
setupContext(clientContext);
final HttpHost resolvedTarget = target != null ? target :
RoutingSupport.determineHost(request);
+ Args.notNull(resolvedTarget, "Target host for the request");
Review Comment:
@arturobernalg This is not right. The target may be null if the request URI
cannot be parsed. It should be up to the specific protocol handler to decide if
such a request can be executed. H2 will likely reject it but HTTP/1.1 may
accept it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
