ok2c commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r2072637431
##########
httpclient5/pom.xml:
##########
@@ -97,6 +97,10 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
Review Comment:
@arturobernalg This is wrong. `commos-compress` must be optional
##########
pom.xml:
##########
@@ -192,6 +193,12 @@
<artifactId>junit-jupiter</artifactId>
<version>${testcontainers.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ <version>${commpress.version}</version>
+ <optional>true</optional>
Review Comment:
@arturobernalg I do not think this has any effect. Anyway,
`dependencyManagement` section is the wrong place to declare artifact's
optionality. This needs to be declared in the module's `dependecies` section,
not here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
