rschmitt commented on code in PR #540:
URL:
https://github.com/apache/httpcomponents-core/pull/540#discussion_r2240224383
##########
pom.xml:
##########
@@ -232,6 +231,7 @@
<parameter>
<breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
+ <ignoreMissingClasses>true</ignoreMissingClasses>
Review Comment:
No, I changed this by hand. This option appeared to be in the wrong section
and wasn't taking effect. Without this option here, japicmp fails because the
current version's classpath is missing the RxJava 2 classes (not to be confused
with the missing `ReactiveTestUtils` class). Evidently, `ignoreMissingClasses`
needs to be set in the build plugin config, not the reporting plugin config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
