garydgregory commented on code in PR #541:
URL:
https://github.com/apache/httpcomponents-core/pull/541#discussion_r2246080997
##########
httpcore5/src/main/java/org/apache/hc/core5/reactor/InternalDataChannel.java:
##########
@@ -166,10 +167,17 @@ void onTimeout(final Timeout timeout) throws IOException {
if (sessionListener != null) {
sessionListener.timeout(currentSession);
}
+
+ final SSLIOSession tlsSession = tlsSessionRef.get();
+ if (tlsSession != null && !tlsSession.isHandshakeComplete()) {
+ throw new TlsHandshakeTimeoutException("TLS handshake timed out
after " + timeout);
Review Comment:
@arturobernalg
I think we should add a timeout only constructor and have the message in
that constructor so it's normalized and not duplicated in each call site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
