ok2c commented on code in PR #553:
URL:
https://github.com/apache/httpcomponents-core/pull/553#discussion_r2334215753
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -1456,6 +1497,9 @@ public void push(final List<Header> headers, final
AsyncPushProducer pushProduce
ioSession.getLock().lock();
try {
+ if (countActiveLocalInitiated() >=
remoteConfig.getMaxConcurrentStreams()) {
Review Comment:
@arturobernalg Imagine being a user who wants to push 10 messages to the
client being completely unaware of the MAX_CONCURRENT_STREAMS limit imposed by
the client and getting some of those messages dropped with some obscure
"Outbound stream limit reached" message. What would be your reaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
