ok2c commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3291489077
@rschmitt This https://github.com/apache/httpcomponents-core/commit/ac42decdf5def442928de4f17eb8d54d3f12c066 should fix the immediate problem with a race between connection status and command submission. This https://github.com/apache/httpcomponents-core/commit/5de2967e1b76ea2adb631ed3a0d7f8a03596d0e7 should make sure that `#disconnected` method of the protocol handler gets executed as late as possible after the underlying i/o session has been fully closed out Both `master` and `5.3.x` no longer get stuck for me due to a command left in a limbo by a race with connection shutdown. ``` h2: Validation disabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Sequential requests (rapid): 2,464 succeeded; 36 failed (98.56% success rate, 1.44% retriable) h2: Validation enabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 30.00% retriable) h2: Validation enabled: Single large batch: 30 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 20.00% retriable) h2: Validation enabled: Multiple small batches: 15 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2c: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Sequential requests (rapid): 2,180 succeeded; 320 failed (87.20% success rate, 12.76% retriable) h2c: Validation enabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 50.00% retriable) h2c: Validation enabled: Single large batch: 30 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 26.67% retriable) h2c: Validation enabled: Multiple small batches: 15 succeeded; 0 failed (100.00% success rate) https: Validation disabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) https: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) https: Validation disabled: Sequential requests (rapid): 1,305 succeeded; 1,195 failed (52.20% success rate, 47.60% retriable) https: Validation enabled: Sequential requests (rapid): 1,316 succeeded; 1,184 failed (52.64% success rate, 47.32% retriable) https: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) https: Validation enabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) https: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 20.00% retriable) https: Validation enabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 6.67% retriable) http: Validation disabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) http: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) http: Validation disabled: Sequential requests (rapid): 1,313 succeeded; 1,187 failed (52.52% success rate, 38.68% retriable) http: Validation enabled: Sequential requests (rapid): 1,332 succeeded; 1,168 failed (53.28% success rate, 38.56% retriable) http: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation enabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) http: Validation enabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
