rschmitt commented on PR #550: URL: https://github.com/apache/httpcomponents-core/pull/550#issuecomment-3299813906
I set this aside for a bit and I'm just coming back to it now. I was looking into this suggestion: > I would also propose this change-set be moved to client and applied by the client builders at the client level and not globally at the core level. I'm not so sure this is a good idea now. We'd have to implement two new implicit defaults. `HttpAsyncClientBuilder` would need a new default `IOReactorConfig`, and `PoolingHttpClientConnectionManagerBuilder` would need a new default `Resolver<HttpRoute, SocketConfig>`. My concern is that a user introducing customization of the IO reactor config or socket config would do so by customizing the default instances in core (`IOReactorConfig.DEFAULT` and `SocketConfig.DEFAULT`), and in so doing would inadvertently shut off TCP keep-alive, which may introduce other problems unrelated to the intended change. I have a high degree of confidence that the settings in this PR are good defaults. Since opening this PR, these settings have been deployed to hundreds of thousands of machines without incident, and our runtime checks catch the remaining situations where these settings aren't supported (e.g. JDK8 on Windows, or Windows Server 2016). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
