rschmitt commented on code in PR #737:
URL:
https://github.com/apache/httpcomponents-client/pull/737#discussion_r2426926646
##########
httpclient5/pom.xml:
##########
@@ -77,11 +77,6 @@
<artifactId>log4j-core</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.brotli</groupId>
- <artifactId>dec</artifactId>
- <optional>true</optional>
- </dependency>
Review Comment:
I'm confused. Why has this dependency declaration been removed? There are
still (reflective) usages of these classes in the library:
```
httpclient5/src/main/java/org/apache/hc/client5/http/entity/BrotliDecompressingEntity.java
52: Class.forName("org.brotli.dec.BrotliInputStream");
httpclient5/src/main/java/org/apache/hc/client5/http/entity/compress/CommonsCompressCodecFactory.java
76: private static final String H_BROTLI =
"org.brotli.dec.BrotliInputStream";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
