ok2c commented on PR #738:
URL:
https://github.com/apache/httpcomponents-client/pull/738#issuecomment-3401625567
@arturobernalg I think it was a misunderstanding.
The problem was this bit of code that used
`CommonsCompressDecoderFactory#runtimeAvailable` to test for availability of
Brotli even if Commons Compress was not on the classpath. There is no problem
linking optional dependencies at compile time.
```
if (!m.containsKey(ContentCoding.BROTLI)
&&
CommonsCompressDecoderFactory.runtimeAvailable(ContentCoding.BROTLI.token())) {
m.put(ContentCoding.BROTLI,
Codec.decodeOnly(ent ->
new DecompressingEntity(ent,
BrotliInputStream::new)));
}
```
I once again did a poor job reviewing your changes but I will try to improve.
I fixed all these problems with 4a34b97a0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
