ok2c commented on code in PR #745:
URL:
https://github.com/apache/httpcomponents-client/pull/745#discussion_r2447451847
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/AuthenticationHandler.java:
##########
@@ -121,8 +121,7 @@ public boolean isChallenged(
}
/**
- * Determines whether the given response represents an authentication
challenge, without
- * changing the {@link AuthExchange} state.
+ * Determines whether the response is 401/407 response depending to the
challengeType
Review Comment:
@stoty Can we avoid using explicit status codes here and use a more generic
"challenge" term?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
