aldexis commented on PR #573: URL: https://github.com/apache/httpcomponents-core/pull/573#issuecomment-3425628373
@ok2c I've made a different change in https://github.com/apache/httpcomponents-core/pull/573/commits/00c68e1104dbc1d09a9a67ce0dd6ea6d8433e394 but this actually seems weird to me. We're already saying "I want to close this connection immediately" and the fact that we need to set the socket timeout to 1ms in certain condition just seems like an abstraction leak 🤔 To be clear in case it wasn't by the way, in my specific case, I believe simply upgrading http-client past 5.3 will be fine, but it seemed incorrect that requesting a connection to close _immediately_ could hand for potentially a long time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
