arturobernalg commented on PR #719: URL: https://github.com/apache/httpcomponents-client/pull/719#issuecomment-3617814161
> > I don't recommend doing this. Package-private (default) visibility is the only reliable Java language mechanism we have to encapsulate implementation details. If we put implementation details in an `impl` package, they all need to be declared `public` just so we can make internal calls to them from our actually-public APIs! > > @rschmitt That seems to imply that public API classes would have some implementation code in them that needed to be kept private / not exposed to the API consumers, because here is nothing stopping classes in impl from re-using package private code within that package. > > I understand this is more of a matter of taste, so let's agree to disagree here and let @arturobernalg decide what approach to take. HttpClient already uses impl subpackages extensively (impl.classic, impl.async, etc.), so following the same pattern here would be consistent with the existing structure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
