arturobernalg commented on PR #581: URL: https://github.com/apache/httpcomponents-core/pull/581#issuecomment-3641576949
> I'd like to see HTTP/2 test coverage added to `httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestAsyncSocketTimeout.java` in the client integration tests. This would provide at least some assurance that we are implementing a consistent contract across the various transports and protocols. @rschmitt I’ve added an async core HTTP/2 socket-timeout test in httpcore5-testing (`AsyncH2SocketTimeoutCoreTest`) that mirrors the client-side `TestAsyncSocketTimeout` behaviour. It verifies that a per-request timeout over HTTP/2 results in HttpStreamResetException, so I believe this covers the contract you were asking for – let me know if you had something different in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
